netdev - Re: [net-next-2.6 PATCH v7 4/7 RFC] TCPCT part 1d: define TCP cookie option, extend existing struct's

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B08C3C6.8010601@gmail.com>
Date:	Sat, 21 Nov 2009 23:53:26 -0500
From:	William Allen Simpson <william.allen.simpson@...il.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org
Subject: Re: [net-next-2.6 PATCH v7 4/7 RFC] TCPCT part 1d: define TCP cookie
 option, extend existing struct's

David Miller wrote:
> From: William Allen Simpson <william.allen.simpson@...il.com>
> Date: Fri, 20 Nov 2009 09:38:12 -0500
> 
>>  static inline void tcp_clear_options(struct tcp_options_received *rx_opt)
>>  {
>> -	rx_opt->tstamp_ok = rx_opt->sack_ok = rx_opt->wscale_ok = rx_opt->snd_wscale = 0;
>> +	rx_opt->tstamp_ok = rx_opt->sack_ok = 0;
>> +	rx_opt->wscale_ok = rx_opt->snd_wscale = 0;
>> +	rx_opt->cookie_plus = 0;
>>  }
>>  
> 
> Why not get the coding style correct wrt. long lines in patch #3 where
> you initially added this function, rather than fixing it here as you
> add the new ->cookie_plus assignment?
> 
Documentation/SubmittingPatches at 619:

One significant exception is when moving code from one file to
another -- in this case you should not modify the moved code at all in
the same patch which moves it.  This clearly delineates the act of
moving the code and your changes.  This greatly aids review of the
actual differences and allows tools to better track the history of
the code itself.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html