netdev - Re: [net-next-2.6 PATCH] net/ipv4: Move && and || to end of previous line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Nov 2009 14:14:06 -0800
From:	Joe Perches <joe@...ches.com>
To:	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Cc:	David Miller <davem@...emloft.net>,
	william.allen.simpson@...il.com, Netdev <netdev@...r.kernel.org>
Subject: Re: [net-next-2.6 PATCH] net/ipv4: Move && and || to end of
 previous line

On Tue, 2009-11-24 at 00:08 +0200, Ilpo Järvinen wrote:
> Certainly better in general already but there is still some work to be 
> done here as now you have an && only line. I guess it mostly has to do 
> with comments but #if... blahblahs could be another type of failure (in 
> automation like this).

The current form is

	if (foo 
#ifdef BAR
	    && bar
#endif
	   )

Another option could be:

#ifdef BAR
	if (foo && bar)
#else
	if (foo)
#endif

In any case, it won't be pretty.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html