netdev - Re: macvlan: fix gso_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091123.142207.14190542.davem@davemloft.net>
Date:	Mon, 23 Nov 2009 14:22:07 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	kaber@...sh.net
Cc:	netdev@...r.kernel.org
Subject: Re: macvlan: fix gso_max_size setting

From: Patrick McHardy <kaber@...sh.net>
Date: Mon, 23 Nov 2009 23:11:07 +0100

> David Miller wrote:
>> From: Patrick McHardy <kaber@...sh.net>
>> Date: Mon, 23 Nov 2009 11:33:06 +0100
>>
>>   
>>> Fix macvlan gso_max_size setting. Based on net-next-2.6.git.
>>
>> Pretty serious defect, maybe net-2.6 material?
> 
> Sure, please take it in net-2.6.

Done, thanks.

>>
>> If someone hits this, it's going to trigger something awful.
> 
> Don't drivers simply drop the packet? Otherwise I think you
> should be able to trigger the same problem using the TC mirred
> action.

I see nothing in the IXGBE driver's transmit code paths which guard
against this.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html