netdev - Re: [PATCH] irq: Add node_affinity CPU masks for smarter irqbalance hints

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87iqczwtia.fsf@basil.nowhere.org>
Date:	Tue, 24 Nov 2009 21:35:41 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	peter.p.waskiewicz.jr@...el.com, peterz@...radead.org,
	arjan@...ux.intel.com, yong.zhang0@...il.com,
	linux-kernel@...r.kernel.org, arjan@...ux.jf.intel.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] irq: Add node_affinity CPU masks for smarter irqbalance hints

Eric Dumazet <eric.dumazet@...il.com> writes:

> David Miller a écrit :
>> From: Eric Dumazet <eric.dumazet@...il.com>
>> Date: Tue, 24 Nov 2009 19:26:15 +0100
>> 
>>> It seems complex to me, maybe optimal thing would be to use a NUMA policy to
>>> spread vmalloc() allocations to all nodes to get a good bandwidth...
>> 
>> vmalloc() and sk_buff's don't currently mix and I really don't see us
>> every allowing them to :-)
>
> I think Peter was referring to tx/rx rings buffers, not sk_buffs.
>
> They (ring buffers) are allocated with vmalloc() at driver init time.

They are typically allocated with dma_alloc_coherent(), which does
allocate a continuous area.  In theory you could do interleaving
with IOMMus, but just putting it on the same node as the device
is probably better.

-Andi
-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html