lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Nov 2009 10:02:20 +0000 From: Arnd Bergmann <arnd@...db.de> To: Patrick McHardy <kaber@...sh.net> Cc: Eric Dumazet <eric.dumazet@...il.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, David Miller <davem@...emloft.net>, Stephen Hemminger <shemminger@...tta.com>, Herbert Xu <herbert@...dor.apana.org.au>, Patrick Mullaney <pmullaney@...ell.com>, "Eric W. Biederman" <ebiederm@...ssion.com>, Edge Virtual Bridging <evb@...oogroups.com>, Anna Fischer <anna.fischer@...com>, bridge@...ts.linux-foundation.org, virtualization@...ts.linux-foundation.org, Jens Osterkamp <jens@...ux.vnet.ibm.com>, Gerhard Stenzel <gerhard.stenzel@...ibm.com>, Mark Smith <lk-netdev@...netdev.nosense.org> Subject: Re: [PATCH 1/4] veth: move loopback logic to common location On Tuesday 24 November 2009 09:51:19 Patrick McHardy wrote: > > + skb_dst_drop(skb); > > + skb->tstamp.tv64 = 0; > > + skb->pkt_type = PACKET_HOST; > > + skb->protocol = eth_type_trans(skb, dev); > > + skb->mark = 0; > > skb->mark clearing should stay private to veth since its usually > supposed to stay intact. The only exception is packets crossing > namespaces, where they should appear like a freshly received skbs. But isn't that what we want in macvlan as well when we're forwarding from one downstream interface to another? I did all my testing with macvlan interfaces in separate namespaces communicating with each other, so I'd assume that we should always clear skb->mark and skb->dst in this function. Maybe I should make the documentation clearer? --- net: clarify documentation of dev_forward_skb Signed-off-by: Arnd Bergmann <arnd@...db.de> --- a/net/core/dev.c +++ b/net/core/dev.c @@ -1433,6 +1433,10 @@ static inline void net_timestamp(struct sk_buff *skb) * dev_forward_skb can be used for injecting an skb from the * start_xmit function of one device into the receive queue * of another device. + * + * The receiving device may be in another namespace, so + * we have to clear all information in the skb that could + * impact namespace isolation. */ int dev_forward_skb(struct net_device *dev, struct sk_buff *skb) { -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists