netdev - RE: Subject: [PATCH 2/6] bna: Brocade 10Gb Ethernet device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1B6CC3D5ACAB014C8BFB6CB1CBD62CADD28A7D6F77@HQ-EXCH-7.corp.brocade.com>
Date:	Thu, 26 Nov 2009 01:01:11 -0800
From:	Debashis Dutt <ddutt@...cade.COM>
To:	Stephen Hemminger <shemminger@...tta.com>,
	Rasesh Mody <rmody@...cade.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Akshay Mathur <amathur@...cade.com>
Subject: RE: Subject: [PATCH 2/6] bna: Brocade 10Gb Ethernet device driver

Hi Stephen, 

We have removed the inconsistent comments in our last submission.

Thanks
--Debashis

-----Original Message-----
From: Stephen Hemminger [mailto:shemminger@...tta.com] 
Sent: Monday, November 23, 2009 8:25 PM
To: Rasesh Mody
Cc: netdev@...r.kernel.org; Adapter Linux Open SRC Team
Subject: Re: Subject: [PATCH 2/6] bna: Brocade 10Gb Ethernet device driver

On Mon, 23 Nov 2009 19:51:01 -0800
Rasesh Mody <rmody@...cade.com> wrote:

> /**
> + * bna_mcast_mac_reset_list()
> + *
> + *  Resets the multicast MAC address list kept by driver.
> + *  Called when the hw gets reset.
> + *
> + * @param[in]  dev  - pointer to BNA device structure
> + *
> + * @return BNA_OK   - successful
> + * @return BNA_FAIL - failed on sanity checks.
> + */
> +void bna_mcast_mac_reset_list(struct bna_dev *dev)
> +{
> +	memset(&dev->mcast_addr[0], 0, sizeof(dev->mcast_addr));
> +}
> +

If you are going to wrap and add kernel-doc to everything,
please check (or get rid of the boilerplate).  This obviously doesn't
take param[in] or return those values.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html