lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 27 Nov 2009 10:06:37 -0700 From: "Patrick Mullaney" <pmullaney@...ell.com> To: <arnd@...db.de> Cc: <bridge@...ts.linux-foundation.org>, <alacrityvm-devel@...ts.sourceforge.net>, <kaber@...sh.net>, <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org> Subject: Re: [PATCH 1/3] netdevice: provide common routine for macvlan and vlan operstate management Thanks. I'll post an updated patch. On Fri, 2009-11-27 at 14:09 +0100, Arnd Bergmann wrote: > On Friday 13 November 2009, Patrick Mullaney wrote: > > @@ -551,7 +532,7 @@ static int macvlan_newlink(struct net_device *dev, > > return err; > > > > list_add_tail(&vlan->list, &port->vlans); > > - macvlan_transfer_operstate(dev); > > + netif_stacked_transfer_operstate(dev, lowerdev); > > return 0; > > } > > > > @@ -591,7 +572,8 @@ static int macvlan_device_event(struct notifier_block *unused, > > switch (event) { > > case NETDEV_CHANGE: > > list_for_each_entry(vlan, &port->vlans, list) > > - macvlan_transfer_operstate(vlan->dev); > > + netif_stacked_transfer_operstate(vlan->dev, > > + vlan->lowerdev); > > break; > > case NETDEV_FEAT_CHANGE: > > list_for_each_entry(vlan, &port->vlans, list) { > > These have the arguments reversed, lowerdev should come first. > > Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists