netdev - Re: tulip : kernel BUG in tulip_up/tulip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091129113659.GA2971@ami.dom.local>
Date:	Sun, 29 Nov 2009 12:36:59 +0100
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Philippe De Muyter <phdm@...qel.be>
Cc:	grundler@...isc-linux.org, kyle@...artin.ca,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: tulip : kernel BUG in tulip_up/tulip_resume

On Sun, Nov 29, 2009 at 01:17:10AM +0100, Jarek Poplawski wrote:
> Philippe De Muyter wrote, On 11/08/2009 11:33 PM:
> > Does someone know what could be wrong and have a fix or should I look myself ?
> 
> Don't know, guess only...

...And maybe a second guess btw. (to try together or separate).

Jarek P.
---

diff --git a/drivers/net/tulip/tulip_core.c b/drivers/net/tulip/tulip_core.c
index 6b2330e..fd32601 100644
--- a/drivers/net/tulip/tulip_core.c
+++ b/drivers/net/tulip/tulip_core.c
@@ -1749,9 +1749,9 @@ static int tulip_suspend (struct pci_dev *pdev, pm_message_t state)
 	if (!netif_running(dev))
 		goto save_state;
 
+	netif_device_detach(dev);
 	tulip_down(dev);
 
-	netif_device_detach(dev);
 	free_irq(dev->irq, dev);
 
 save_state:
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html