lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Nov 2009 11:30:42 +0100 From: Eric Dumazet <eric.dumazet@...il.com> To: leitao@...ux.vnet.ibm.com CC: netdev@...r.kernel.org, mchan@...adcom.com Subject: Re: [PATCH] bnx2: avoid flushing statistics when doing a MTU change leitao@...ux.vnet.ibm.com a écrit : > Actually when bnx2 changes the interface's MTU size, it resets > the chip and consequently flushes the interface statistics. > This patch saves the statistics in a temporary space in order to > maintain the statistics correct after the chip reset. > > Signed-off-by: Breno Leitao<leitao@...ux.vnet.ibm.com> > return net_stats; > } > @@ -6989,6 +7004,11 @@ bnx2_change_ring_size(struct bnx2 *bp, u32 rx, u32 tx) > { > if (netif_running(bp->dev)) { > bnx2_netif_stop(bp); I wonder if you need to renew this stats before copying them ? (eg calling bnx2_get_stats()) > + > + /* Save statistics that is going to be reseted */ > + memcpy(bp->stats_extra, &bp->dev->stats, > + sizeof(struct net_device_stats)); > + > bnx2_reset_chip(bp, BNX2_DRV_MSG_CODE_RESET); > bnx2_free_skbs(bp); > bnx2_free_mem(bp); > @@ -7649,6 +7669,7 @@ bnx2_init_board(struct pci_dev *pdev, struct net_device *dev) > > bp->flags = 0; > bp->phy_flags = 0; > + bp->stats_extra = kzalloc(sizeof(struct net_device_stats), GFP_KERNEL); There is no test of failed allocation. > > /* enable device (incl. PCI PM wakeup), and bus-mastering */ > rc = pci_enable_device(pdev); > @@ -8162,6 +8183,7 @@ bnx2_remove_one(struct pci_dev *pdev) > if (bp->regview) > iounmap(bp->regview); > > + kfree(bp->stats_extra); > free_netdev(dev); > pci_release_regions(pdev); > pci_disable_device(pdev); Structure is small anyway, why not including it in struct bnx2 ? -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists