netdev - Re: dmfe/tulip device id overlap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091130065512.GA2792@jenkins.domain_not_set.invalid>
Date:	Sun, 29 Nov 2009 22:55:12 -0800
From:	Brandon Philips <brandon@...p.org>
To:	David Miller <davem@...emloft.net>
Cc:	grundler@...gle.com, tobias@...gis.se, kyle@...artin.ca,
	netdev@...r.kernel.org, grundler@...isc-linux.org
Subject: Re: dmfe/tulip device id overlap

Hello Dave-

On 00:30 Sun 29 Nov 2009, David Miller wrote:
> From: Grant Grundler <grundler@...gle.com>
> Date: Wed, 25 Nov 2009 09:24:54 -0800
> 
> > I'm ok with this patch except the mention of Ubuntu in the comment is
> > superfluous. All the distro's will share this problem. I trust davem
> > to rewrite the comment and plase add my:
> >     Signed-off-by: Grant Grundler <grundler@...isc-linux.org>
> 
> Please remove the comment and the __sparc__ ifdef.

The comment and the __sparc__ ifdef is the entire patch... so you NACK
the whole patch?? ;)

> If tulip doesn't work on some sparc systems we simply need to fix
> it.

Tulip works on sparc as described in the linux-sparc[1] thread.  The
problem as I understand it:

tulip works for the 0x9100 and 0x9102 parts that were onboard a few
sparc motherboards.

But, those same device IDs are used by a set of Davicom PCI cards that
only work with the dmfe driver.

Thus, the patch only lets tulip handle 0x9100 and 0x9102 if __sparc__.

Perhaps someone knows if there is a way to tell the PCI card from the
sparc builtin machine?

Cheers,

	Brandon

[1] http://marc.info/?l=linux-sparc&m=123698696912216&w=2
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html