netdev - Re: [RFC PATCH 00/10] Remove skb_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091129.234037.232627669.davem@davemloft.net>
Date:	Sun, 29 Nov 2009 23:40:37 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	alexander.h.duyck@...el.com
Cc:	mcarlson@...adcom.com, mchan@...adcom.com,
	sathyap@...verengines.com, subbus@...verengines.com,
	netdev@...r.kernel.org
Subject: Re: [RFC PATCH 00/10] Remove skb_dma_map/unmap calls

From: Alexander Duyck <alexander.h.duyck@...el.com>
Date: Tue, 24 Nov 2009 17:20:12 -0800

> This patch series removes the skb_dma_map and skb_dma_unmap function calls.
> The reason for this change is because the use of skb_dma_map/unmap can lead
> to serious issues when HW IOMMU is enabled.  This is because each mapping
> of the skb with a HW IOMMU enabled results in a new set of DMA mappings.
> This in turn leads to issues when skbs are cloned for uses such as
> bridging or pktgen because each transmitting device will update the skb
> shared info structure resulting in some mappings being overwritten, and others
> being freed multiple times.
> 
> I am looking for input specifically on the tg3, be2net, and bnx2 driver
> patches as I am not very familiar with them and I am not certain if
> additional changes are required.
> 
> I have included the changes for the Intel wired Ethernet drivers as a
> reference.

These changes look good, but at least one of them does not apply
to current net-2.6

Can you respin this against current sources?

Thanks a lot for doing this work Alexander.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html