netdev - [PATCH] ethtool: Fix switch on port type

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1259683615.2831.16.camel@achroite.uk.solarflarecom.com>
Date:	Tue, 01 Dec 2009 16:06:55 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeff Garzik <jeff@...zik.org>
Cc:	PJ Waskiewicz <peter.p.waskiewicz.jr@...el.com>,
	netdev@...r.kernel.org
Subject: [PATCH] ethtool: Fix switch on port type

The new port type cases in commit 6e0512c 'ethtool: Add Direct Attach
to the available connector ports' were somehow inserted into the
switch on duplex type, not on port type.  Move them to the correct
place.

Signed-off-by: Ben Hutchings <bhutchings@...arflare.com>
---
 ethtool.c |   12 ++++++------
 1 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/ethtool.c b/ethtool.c
index df02e91..10dfc80 100644
--- a/ethtool.c
+++ b/ethtool.c
@@ -965,12 +965,6 @@ static int dump_ecmd(struct ethtool_cmd *ep)
 	case DUPLEX_FULL:
 		fprintf(stdout, "Full\n");
 		break;
-	case PORT_DA:
-		fprintf(stdout, "Direct Attach Copper\n");
-		break;
-	case PORT_NONE:
-		fprintf(stdout, "None\n");
-		break;
 	default:
 		fprintf(stdout, "Unknown! (%i)\n", ep->duplex);
 		break;
@@ -993,6 +987,12 @@ static int dump_ecmd(struct ethtool_cmd *ep)
 	case PORT_FIBRE:
 		fprintf(stdout, "FIBRE\n");
 		break;
+	case PORT_DA:
+		fprintf(stdout, "Direct Attach Copper\n");
+		break;
+	case PORT_NONE:
+		fprintf(stdout, "None\n");
+		break;
 	case PORT_OTHER:
 		fprintf(stdout, "Other\n");
 		break;
-- 
1.5.5

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html