netdev - Re: [PATCH] sch_htb: ix the deficit overflows

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B156BF1.7060407@gmail.com>
Date:	Tue, 01 Dec 2009 20:18:09 +0100
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Changli Gao <xiaosuo@...il.com>
CC:	Jamal Hadi Salim <hadi@...erus.ca>,
	"David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
	Martin Devera <martin.devera@....cz>
Subject: Re: [PATCH] sch_htb: ix the deficit overflows

Jarek Poplawski wrote, On 12/01/2009 08:12 PM:

> So, as I wrote before, your proposal based on the first variant is
> acceptable to me, but please reconsider the second idea too, e.g.
> done like this:
> 
>                  }
>                  /* this used to be after charge_class but this constelation
>                     gives us slightly better performance */
>                  if (!cl->un.leaf.q->q.qlen) {
>                          htb_deactivate(q, cl);
> +			 if (unlikely(cl->un.leaf.deficit[level] < cl->quantum)) {

Should be:
 +			 if (unlikely(cl->un.leaf.deficit[level] < -cl->quantum)) {

Jarek P.

> +				{ a warning }
> +                      	 	cl->un.leaf.deficit[level] = 0;
> +			 }
>  		 }
>                  htb_charge_class(q, cl, level, skb);
>          }
>          return skb;
>  }
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html