netdev - Re: [PATCH 2/3] Add new (iptables 1.4.5 compatible) tc/ipt/xt module.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1259773969.9431.41.camel@amd64.fatal.se>
Date:	Wed, 02 Dec 2009 18:12:49 +0100
From:	Andreas Henriksson <andreas@...al.se>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH 2/3] Add new (iptables 1.4.5 compatible) tc/ipt/xt
 module.

On ons, 2009-12-02 at 08:58 -0800, Stephen Hemminger wrote:
> On Wed, 2 Dec 2009 16:11:50 +0100
> Andreas Henriksson <andreas@...al.se> wrote:
> 
> > Add a new cleaned up m_xt.c based on m_xt_old.c
[..]
> Will this still build on older versions?  The iproute source is supposed
> to build even with really old kernels and older iptables. It has
> maintained source and binary compatibility.
> 

Which of tc/m_ipt.c, tc/m_xt_old.c and tc/m_xt.c will be built depends
on which version of iptables you have installed.
The configure script sets matching flags in Config and tc/Makefile picks
that up and includes the suitable source file.

So tc/m_xt.c will not build with older iptables and it won't be used
with older iptables.

This is not ideal, since if the xtables headers can't be found (ie. the
iptables-dev package isn't installed) the ancient m_ipt.c will be built
and the brokenness won't be detected until the user tries to use the
module.

Distributors will need to watch out for this. It's currently broken in
atleast fedora and debian.

-- 
Regards,
Andreas Henriksson
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html