netdev - Re: [PATCH v2] net: Introduce realloc_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091203163640.GA2584@ami.dom.local>
Date:	Thu, 3 Dec 2009 17:36:40 +0100
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>, mchan@...adcom.com,
	kaber@...sh.net, netdev@...r.kernel.org
Subject: Re: [PATCH v2] net: Introduce realloc_netdev_mq()

On Thu, Dec 03, 2009 at 04:17:43PM +0100, Eric Dumazet wrote:
> Jarek Poplawski a écrit :
> > Take 2 (with forgotten headers, sorry).
> 
> Very nice, thanks !
> 
> > Here is a proposal of netdev api change. I hope Michael finds time
> > to try if this can be really useful for drivers.
> > 
> > Thanks,
> > Jarek P.
> > ---------------> (take 2)
> > 
> > This patch separates allocation of TX subqueues from alloc_netdev_mq()
> > to realloc_netdev_mq() to allow for resizing like in this example:
> > 
> > some_nic_probe()
> > {
> > 	...
> > 	dev = alloc_etherdev_mq(sizeof(*bp), 1)
> > 	...
> > 	if (MSI-X_available && device_supports_MSI-X_and_multiqueue)
> > 		realloc_netdev_mq(dev, TX_MAX_RINGS)
> > 	register_netdev(dev)
> > 	...
> > }
> > 
> 
> Or the reverse :
> 
> ie, the device first allocate its max possible tx rings
> 
> dev = alloc_etherdev_mq(sizeof(*bp), 128)
> 
> then, later, try to reduce it, when knowing exact tx count.

Right, especially when we know it's a common config/capability for
a NIC.

> 
> if (realloc_netdev_mq(dev, real_queues))
> 	dev->real_num_tx_queues = real_queues;
> 
> In this case the memory error is not fatal.

Good point! We can consider doing this inside the function too?

Thanks,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html