netdev - Re: [net-next-2.6 PATCH v9 2/2] TCPCT part 1i: remove old tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B184FC1.8020805@gmail.com>
Date:	Thu, 03 Dec 2009 18:54:41 -0500
From:	William Allen Simpson <william.allen.simpson@...il.com>
To:	Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [net-next-2.6 PATCH v9 2/2] TCPCT part 1i: remove old tcp_optlen()
 function

In the only two existing files using the old tcp_optlen() function,
clean up confusing and inconsistent mixing of both byte and word
offsets.  Document assumptions.  David Miller's review sayeth:

    This is transmit, and the packets can only come from the Linux
    TCP stack, not some external entity.

Untested.  No response from testers in 6+ weeks.

Signed-off-by: William.Allen.Simpson@...il.com
CC: Michael Chan <mchan@...adcom.com>
---
  drivers/net/bnx2.c  |   22 +++++++++++++---------
  drivers/net/tg3.c   |   51 +++++++++++++++++++++++----------------------------
  include/linux/tcp.h |    5 -----
  3 files changed, 36 insertions(+), 42 deletions(-)

View attachment "TCPCT+1i9.patch" of type "text/plain" (5568 bytes)