netdev - Re: [PATCH] virtio_net: add more ethtool information

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200912041032.23865.rusty@rustcorp.com.au>
Date:	Fri, 4 Dec 2009 10:32:23 +1030
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Alex Williamson <alex.williamson@...com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] virtio_net: add more ethtool information

On Thu, 3 Dec 2009 05:02:26 pm Stephen Hemminger wrote:
> It is useful for some tools (as well as bonding, and bridging)
> for virtio network interface provide more ethtool information.

Hi Stephen,

    Can't see any harm.  Some minor questions below:

> 
> Signed-off-by: Stephen Hemminger <shemminger@...tta.com>
> 
> --- a/drivers/net/virtio_net.c	2009-12-01 14:24:14.766450584 -0800
> +++ b/drivers/net/virtio_net.c	2009-12-01 16:49:18.295535415 -0800
> @@ -763,7 +763,36 @@ static void virtnet_vlan_rx_kill_vid(str
>  		dev_warn(&dev->dev, "Failed to kill VLAN ID %d.\n", vid);
>  }
>  
> +static void virtnet_get_drvinfo(struct net_device *dev,
> +				struct ethtool_drvinfo *info)
> +{
> +	struct virtnet_info *vi = netdev_priv(dev);
> +
> +	strcpy(info->driver, "virtnet");
> +	strcpy(info->version, "0.1");
> +	strcpy(info->fw_version, "N/A");
> +	strcpy(info->bus_info, dev_driver_string(&vi->vdev->dev));

0.1 as a version is weird.  If we need a number, "0" seems best.

> +	cmd->speed = SPEED_1000;

Why 1000?  Because it's commong?  How about a SPEED_UNLIMITED?

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html