netdev - Re: [PATCH net-next-2.6] tcp: diag: Dont report negative values for rx queue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20091203.160623.238913212.davem@davemloft.net>
Date:	Thu, 03 Dec 2009 16:06:23 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next-2.6] tcp: diag: Dont report negative values
 for rx queue

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Thu, 03 Dec 2009 19:54:40 +0100

> Both netlink and /proc/net/tcp interfaces can report transient
> negative values for rx queue.
> 
> ss ->
> State   Recv-Q Send-Q  Local Address:Port  Peer Address:Port
> ESTAB   -6     6       127.0.0.1:45956     127.0.0.1:3333 
> 
> netstat ->
> tcp   4294967290      6 127.0.0.1:37784  127.0.0.1:3333 ESTABLISHED
> 
> This is because we dont lock socket while computing 
> tp->rcv_nxt - tp->copied_seq,
> and another CPU can update copied_seq before rcv_next in RX path.
> 
> 
> Signed-off-by: Eric Dumazet <eric.dumazet@...il.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html