netdev - Re: [PATCH v4] net: Introduce realloc_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091204114147.GA8488@ff.dom.local>
Date:	Fri, 4 Dec 2009 11:41:47 +0000
From:	Jarek Poplawski <jarkao2@...il.com>
To:	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Cc:	Eric Dumazet <eric.dumazet@...il.com>,
	David Miller <davem@...emloft.net>,
	"mchan@...adcom.com" <mchan@...adcom.com>,
	"kaber@...sh.net" <kaber@...sh.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
Subject: Re: [PATCH v4] net: Introduce realloc_netdev_mq()

On Fri, Dec 04, 2009 at 02:51:38AM -0800, Peter P Waskiewicz Jr wrote:
> Honestly, there's no reason we can't know how many Tx queues we'll have
> prior to registering the netdev.  All of this should be figured out
> after ixgbe_alloc_queues() and ixgbe_init_interrupt_scheme() are called.
> 
> Once we know what features are enabled, and how many MSI-X vectors the
> platform gives us, we can make the call for how many queues to allocate.

Yes. It seems, it's more about cleaning/reordering a few things
sometimes.

> 
> I like this realloc_netdev_mq() mechanism.  I'm going to pull that into
> my tree for testing, since I unfortunately was unaware it existed (lack
> of my poking around).  This is good stuff.

Actually, it's only a simple separation of functionality, no big deal,
but thanks. Since it's still a part of RFC feel free to make it better
or even different way.

Cheers,
Jarek P.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html