netdev - Re: [PATCH] net: Modify return value for the .ndo_set_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091204.133018.10228592.davem@davemloft.net>
Date:	Fri, 04 Dec 2009 13:30:18 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	"kirjanov@...il.com"@sunset.davemloft.net.davemloft.net,
	kirjanov@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: Modify return value for the .ndo_set_mac_address

From: "Denis Kirjanov <kirjanov@...il.com" <kirjanov@...il.com>
Date: Fri, 4 Dec 2009 14:47:22 +0300

> Return -EADDRNOTAVAIL insted of -EINVAL in .ndo_set_mac_address.
> 
> Signed-off-by: Denis Kirjanov <kirjanov@...il.com>

Why?

The address is "invalid" so we return "invalid" error.

What's the problem?

And whether there is a good reason or not, your commit message did not
describe that reason so needs to be updated.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html