netdev - Re: RFC: how to control device specific features. sysfs or mod param?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1260008573.3565.17.camel@localhost>
Date:	Sat, 05 Dec 2009 02:22:53 -0800
From:	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
To:	David Miller <davem@...emloft.net>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: RFC: how to control device specific features. sysfs or mod
 param?

On Sat, 2009-12-05 at 02:13 -0800, David Miller wrote:
> From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
> Date: Sat, 05 Dec 2009 01:55:55 -0800
> 
> > My question is I want to toggle the underlying hardware mode to use one
> > or the other filter mechanism.  I can either do this using a module
> > parameter, which I'd like to avoid, or I can do this in a sysfs
> > parameter.  What do people think is the best approach?  Is there another
> > option I'm not considering here?
> 
> Other than sysfs another option to consider is trying to fit
> this into the ethtool framework somehow.

Yes, I looked at either ethtool or extending any of the existing
rtnetlink interfaces.  But my problem with those is this setting is very
specific to my hardware, and I'm not sure anyone else could benefit from
this.

I could try and make it as generic as possible, say pass a 32 or 64-bit
generic bitfield to a driver through an ethtool operation, and each
driver would apply some secret sauce based on the bitfield?

The sysfs option seems somewhat natural though.  It's part of the driver
itself, and would be a toggle switch for that specific driver.

I have no attachment to any of these options.  I just want whatever is
maintainable, makes sense, and if others can benefit, that's a great
bonus.

-PJ

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html