netdev - Re: [PATCH net-next-2.6] drivers/net: Move && and || to end of previous line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1260035440.11126.50.camel@Joe-Laptop.home>
Date:	Sat, 05 Dec 2009 09:50:40 -0800
From:	Joe Perches <joe@...ches.com>
To:	William Allen Simpson <william.allen.simpson@...il.com>
Cc:	Brice Goglin <brice@...i.com>, David Miller <davem@...emloft.net>,
	netdev@...r.kernel.org,
	Linux Kernel Developers <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6] drivers/net: Move && and || to end of
 previous line

On Sat, 2009-12-05 at 07:43 -0500, William Allen Simpson wrote:
> Joe Perches wrote:
> > On Fri, 2009-12-04 at 14:10 +0100, Brice Goglin wrote:
> >> Joe Perches wrote:
> >>> Only files where David Miller is the primary git-signer.
> >>> wireless, wimax, ixgbe, etc are not modified.
> >> What's the point? Having them at the beginning of the next line is
> >> easier to read from my point of view.
> > It's just a stupid consistency thing.
> Joe *agrees* that
> having them on the beginning of the line is preferred.

This is not true.

I prefer code that I write for myself to
use leading continuation tests.

For the Linux code, as should be obvious
from the patches I submit, I prefer to
have adherence to one predominant majority
style.  I don't much care what form that
style actually takes.

> Thousands of
> contributors throughout the tree agree.
> This is entirely a Miller thing.

Nope.  There have been many efforts to
help standardize on single form styles.

> My main objection to these sweeping patches is that it makes it much
> more difficult to maintain and apply patches across different versions of
> the tree.

I think you underestimate the value of
standardization and overestimate the
quantity of work to sort it out for
the -stable versions.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html