netdev - Re: [PATCH net-next-2.6] drivers/net: Move && and || to end of previous line

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B1B26B6.2060506@gmail.com>
Date:	Sat, 05 Dec 2009 22:36:22 -0500
From:	William Allen Simpson <william.allen.simpson@...il.com>
To:	Joe Perches <joe@...ches.com>
CC:	Brice Goglin <brice@...i.com>, David Miller <davem@...emloft.net>,
	netdev@...r.kernel.org,
	Linux Kernel Developers <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next-2.6] drivers/net: Move && and || to end of previous
 line

Joe Perches wrote:
> On Sat, 2009-12-05 at 07:43 -0500, William Allen Simpson wrote:
>> My main objection to these sweeping patches is that it makes it much
>> more difficult to maintain and apply patches across different versions of
>> the tree.
> 
> I think you underestimate the value of
> standardization and overestimate the
> quantity of work to sort it out for
> the -stable versions.
> 
As I mentioned to somebody in private email (having kept rough track), it
took around 9 hours this week for my 8 patch series, spread over 3 days
because of the tedium.  Fix rejects, visually check patch against previous
version, compile, test -- at least 1/2 to 1 hour for each numbered patch.
Plus time to resubmit the patch series to the list again.

Of course, that was only for the initial patches already posted to the
list.  I've many more -- awaiting approval for the previous set....

Eventually, I have to do the same for each supported -stable version.

Multiply by thousands of contributors.

Hopefully, you did the same, carefully checking your regexp generated
patches visually line by line, and compiling, and testing every driver
in this large patch individually.

I'm not a big believer in making trivial formatting changes and assuming
they work.  Or that I didn't fumble fingers somehow.  I've made many such
stupid mistakes over the years.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html