netdev - Re: [PATCH] ixgbe: allow tx of pre-formatted vlan tagged packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 7 Dec 2009 12:50:01 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Gurucharan Shetty <gshetty@...erbed.com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Arthur Jones <Arthur.Jones@...erbed.com>
Subject: Re: [PATCH] ixgbe: allow tx of pre-formatted vlan tagged packets

On Mon, Dec 7, 2009 at 12:04, Gurucharan Shetty <gshetty@...erbed.com> wrote:
> ixgbe: allow tx of pre-formatted vlan tagged packets
>
> When the 82598 is fed 802.1q packets, it chokes with
> an error of the form:
>
> ixgbe: eth0: ixgbe_tx_csum: partial checksum but proto=81!
>
> As the logic there was not smart enough to look into
> the vlan header to pick out the encapsulated protocol.
>
> There are times when we'd like to send these packets
> out without having to configure a vlan on the interface.
> Here we check for the vlan tag and allow the packet to
> go out with the correct hardware checksum.
>
> This patch is a clone of a previously submitted patch by
> Arthur Jones <ajones@...erbed.com> for igb (Commit -
> fa4a7ef36ec834fee1719636b30d2f28f4cb0166).
>
> Signed-off-by: Gurucharan Shetty <gshetty@...erbed.com>
> Signed-off-by: Arthur Jones <ajones@...erbed.com>
>
> diff --git a/drivers/net/ixgbe/ixgbe_main.c b/drivers/net/ixgbe/ixgbe_main.c
> index 77b0381..4eff407 100644
> --- a/drivers/net/ixgbe/ixgbe_main.c
> +++ b/drivers/net/ixgbe/ixgbe_main.c
> @@ -4810,7 +4810,18 @@ static bool ixgbe_tx_csum(struct ixgbe_adapter *adapter,
>                                    IXGBE_ADVTXD_DTYP_CTXT);
>
>                if (skb->ip_summed == CHECKSUM_PARTIAL) {
> -                       switch (skb->protocol) {
> +                       __be16 protocol;
> +
> +                       if (skb->protocol == cpu_to_be16(ETH_P_8021Q)) {
> +                               const struct vlan_ethhdr *vhdr =
> +                                       (const struct vlan_ethhdr *)skb->data;
> +
> +                               protocol = vhdr->h_vlan_encapsulated_proto;
> +                       } else {
> +                               protocol = skb->protocol;
> +                       }
> +
> +                       switch (protocol) {
>                        case cpu_to_be16(ETH_P_IP):
>                                type_tucmd_mlhl |= IXGBE_ADVTXD_TUCMD_IPV4;
>                                if (ip_hdr(skb)->protocol == IPPROTO_TCP)
>
>

Thanks, I have updated the patch in my queue.

-- 
Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html