netdev - RE: [RFC PATCH 12/12] ixgbevf: Kconfig, Makefile and Documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <43F901BD926A4E43B106BF17856F07558C0F4B7F@orsmsx508.amr.corp.intel.com>
Date:	Tue, 8 Dec 2009 14:49:21 -0800
From:	"Rose, Gregory V" <gregory.v.rose@...el.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>
Subject: RE: [RFC PATCH 12/12] ixgbevf: Kconfig, Makefile and Documentation

>-----Original Message-----
>From: Randy Dunlap [mailto:randy.dunlap@...cle.com]
>Sent: Tuesday, December 08, 2009 2:42 PM
>To: Kirsher, Jeffrey T
>Cc: netdev@...r.kernel.org; gospo@...hat.com; Rose, Gregory V
>Subject: Re: [RFC PATCH 12/12] ixgbevf: Kconfig, Makefile and
>Documentation
>
>> +The ixgbevf driver supports 82599-based virtual function devices that
>can only
>> +be activated on kernels with CONFIG_PCI_IOV enabled.
>> +
>> +The guest OS loading the ixgbevf driver must support MSI-X
>interrupts.
>
>Hi,
>
>Could the Kconfig language express some of these requirements, or
>am I confused between the host and the guest OS?
[Rose, Gregory V] 

The guest OS must also support MSI-X interrupts.  It is a requirement of our VF device to use MSI-X.

>
>
>> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
>> index 0bbd5ae..a484415 100644
>> --- a/drivers/net/Kconfig
>> +++ b/drivers/net/Kconfig
>> @@ -2614,6 +2614,27 @@ config IXGBE_DCB
>>
>>  	  If unsure, say N.
>>
>> +config IXGBEVF
>> +       tristate "Intel(R) 82599 Virtual Function Ethernet support"
>> +       depends on PCI
>
>	depends on PCI_IOV && PCI_MSI
>??
>
[Rose, Gregory V] 

The guest does not need to have IOV support configured to use the VF device but it does need MSI-X.  We'll incorporate this suggested change.

Thanks for your comments.

- Greg

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html