netdev - Re: [PATCH] net: dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091208.203503.45117329.davem@davemloft.net>
Date:	Tue, 08 Dec 2009 20:35:03 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	ilpo.jarvinen@...sinki.fi, shemminger@...tta.com,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: dst_release() cleanup

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Mon, 07 Dec 2009 20:13:14 +0100

> Ilpo J.$(D+#.(Brvinen a .$(D+1.(Bcrit :
> 
>> That's their problem then to fix all relevant places. ...That won't even 
>> compile because of constructs like this:
>> 
>> 	if (WARN_ON(x))
>> 
>> ...To my knowing this perfectly legal way of doing this.
>> 
> 
> Sure, but let be conservative :)

It certainly jumped out at me.

Using side effects in a debugging macro, that's always asking for
trouble.  Every time I see this thing I'm going to do a double
take on it.

We can pull the return value into an 'int' with a descriptive name
such as "orig_dst_refcnt", and also use WARN() to make a descriptive
error message for kerneloops.org to log if it triggers.

Ok Eric?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html