netdev - Re: [PATCH] net: Handle NETREG_UNINITIALIZED devices correctly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B1F7498.2090007@gmail.com>
Date:	Wed, 09 Dec 2009 10:57:44 +0100
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Krishna Kumar <krkumar2@...ibm.com>
CC:	davem@...emloft.net, herbert@...dor.apana.org.au,
	netdev@...r.kernel.org
Subject: Re: [PATCH] net: Handle NETREG_UNINITIALIZED devices correctly

Krishna Kumar a écrit :
> From: Krishna Kumar <krkumar2@...ibm.com>
> 
> Fix two problems:
> 
> 1. If unregister_netdevice_many() is called with both registered
>    and unregistered devices, rollback_registered_many() bails out
>    when it reaches the first unregistered device. The processing
>    of the prior registered devices is unfinished, and the
>    remaining devices are skipped, and possible registered netdev's
>    are leaked/unregistered.
> 
> 2. System hangs or panics depending on how the devices are passed,
>    since when netdev_run_todo() runs, some devices were not fully
>    processed.
> 
> Tested by passing intermingled unregistered and registered vlan
> devices to unregister_netdevice_many() as follows:
> 	1. dev, fake_dev1, fake_dev2: hangs in run_todo
> 	   ("unregister_netdevice: waiting for eth1.100 to become
> 	    free. Usage count = 1")
> 	2. fake_dev1, dev, fake_dev2: failure during de-registration
> 	   and next registration, followed by a vlan driver Oops
> 	   during subsequent registration.
> 
> Confirmed that the patch fixes both cases.
> 
> Signed-off-by: Krishna Kumar <krkumar2@...ibm.com>

Acked-by: Eric Dumazet <eric.dumazet@...il.com>

Thanks !
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html