netdev - Re: [PATCH] Add sysctl to set the advertised TCP initial receive window.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1260392131.5351.43.camel@Joe-Laptop.home>
Date:	Wed, 09 Dec 2009 12:55:31 -0800
From:	Joe Perches <joe@...ches.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	chavey@...gle.com, davem@...emloft.net, netdev@...r.kernel.org,
	therbert@...gle.com
Subject: Re: [PATCH] Add sysctl to set the advertised TCP initial receive
 window.

On Wed, 2009-12-09 at 21:33 +0100, Eric Dumazet wrote:
> Le 09/12/2009 21:13, chavey@...gle.com a écrit :
> > Add a sysctl, tcp_init_rcv_wnd, to set the TCP initial receive window
> > size advertised by passive and active TCP connections.
> > index f1813bc..7567edd 100644
> > --- a/net/ipv4/tcp.c
> > +++ b/net/ipv4/tcp.c
> > @@ -2248,6 +2248,11 @@ static int do_tcp_setsockopt(struct sock *sk, int level,
> >  		break;
> >  #endif
> >  
> > +	case TCP_INIT_RCV_WND:
> > +		val = min_t(int, val, TCP_INIT_RCV_WND_MAX);
> > +		tp->rx_opt.init_rcv_wnd = val;
> > +		break;
> > +
> 
> If user pass val = -1, you end with init_rcv_wnd = 255
> 
> Is it what you want ?
> Probably not :)

I believe min_t() is superfluous now because:
+               .proc_handler   = proc_dointvec_minmax,
+               .extra1         = &zero,
+               .extra2         = &tcp_init_rcv_wnd_max


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html