[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4B20FC2E.7050809@gmail.com>
Date: Thu, 10 Dec 2009 08:48:30 -0500
From: William Allen Simpson <william.allen.simpson@...il.com>
To: Andrew Morton <akpm@...ux-foundation.org>
CC: davem@...emloft.net,
Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: + net-ipv4-tcpc-fix-warning.patch added to -mm tree
Andrew Morton wrote:
> On Tue, 08 Dec 2009 20:45:53 -0500
> William Allen Simpson <william.allen.simpson@...il.com> wrote:
>> I didn't have this warning, how in the world do you get it?
>
> Used gcc-4.0.2. They re-randomise the warnings with each release I think.
>
Using gcc-4.4.1 here, and the usual 'make -s -j4 vmlinux'.
>> This is what David calls my "anal" coding style. I check everything,
>> because someday somebody else might make a change, and it's important
>> that such problems be detected. In this case, I assume the compiler
>> will compile them out or it would have no effect, and commented that
>> it should be impossible.
>>
>> Your test should probably be TCP_MSS_DEFAULT < TCP_COOKIE_PAIR_SIZE
>
> I'd say just delete it ;)
>
Well, David said he would, but nothing seems to have happened, so I'll
send a short patch in my next message.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists