netdev - Re: [PATCH] gianfar: Fix a filer bug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091210150712.GA17851@oksana.dev.rtsoft.ru>
Date:	Thu, 10 Dec 2009 18:07:12 +0300
From:	Anton Vorontsov <avorontsov@...mvista.com>
To:	Sandeep Gopalpet <Sandeep.Kumar@...escale.com>
Cc:	netdev@...r.kernel.org, davem@...emloft.net
Subject: Re: [PATCH] gianfar: Fix a filer bug

On Wed, Dec 09, 2009 at 07:25:11PM +0530, Sandeep Gopalpet wrote:
> We need to enable filer whenever we need to use multiple RX
> queues. Also, need to program RIR0 register with the required
> distribution we require, if using RX filer hashing support for
> packet distribution to multiple queues.
> 
> Signed-off-by: Sandeep Gopalpet <Sandeep.Kumar@...escale.com>
> ---
[...]
> -	if (priv->rx_filer_enable)
> +	if (priv->rx_filer_enable) {
>  		rctrl |= RCTRL_FILREN;
> +		/* Program the RIR0 reg with the required distribution */
> +		regs->rir0 = DEFAULT_RIR0;

You cannot access regs directly. You have to use gfar_write
since regs is ioremapped memory.

Thanks,

-- 
Anton Vorontsov
email: cbouatmailru@...il.com
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html