netdev - RE: [RFC] gianfar: Fix stats support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9F4C7D19E8361D4C94921B95BE08B81BA08B37@zin33exm22.fsl.freescale.net>
Date:	Fri, 11 Dec 2009 10:20:35 +0530
From:	"Kumar Gopalpet-B05799" <B05799@...escale.com>
To:	<avorontsov@...mvista.com>
Cc:	<eric.dumazet@...il.com>, <netdev@...r.kernel.org>,
	<davem@...emloft.net>
Subject: RE: [RFC] gianfar: Fix stats support

 
>> diff --git a/drivers/net/gianfar.c b/drivers/net/gianfar.c index 
>> 73ccb07..7e6f4e4 100644
>> --- a/drivers/net/gianfar.c
>> +++ b/drivers/net/gianfar.c
>> @@ -143,6 +143,7 @@ void gfar_start(struct net_device *dev);  static 
>> void gfar_clear_exact_match(struct net_device *dev);  static void 
>> gfar_set_mac_for_addr(struct net_device *dev, int num, u8 *addr);  
>> static int gfar_ioctl(struct net_device *dev, struct ifreq *rq, int 
>> cmd);
>> +static struct net_device_stats *gfar_get_stats(struct net_device 
>> +*dev);
>
>Just a cosmetic nitpick: please avoid adding new forward declarations.
>
>In this case I think you could easily move this function 
>before gfar_netdev_ops.
>

OK. Will send out a new patch.

--

Thanks
Sandeep
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html