netdev - [PATCH] mlx4_core: return a negative error value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B23EA51.30504@gmail.com>
Date:	Sat, 12 Dec 2009 20:09:05 +0100
From:	Roel Kluin <roel.kluin@...il.com>
To:	netdev@...r.kernel.org, yevgenyp@...lanox.co.il,
	Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: [PATCH] mlx4_core: return a negative error value

The return value should be negative.

Signed-off-by: Roel Kluin <roel.kluin@...il.com>
---
 drivers/net/mlx4/sense.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

This is a cleanup, its only caller, mlx4_do_sense_ports()
acts on any non-zero error values as well.

diff --git a/drivers/net/mlx4/sense.c b/drivers/net/mlx4/sense.c
index f36ae69..015fbe7 100644
--- a/drivers/net/mlx4/sense.c
+++ b/drivers/net/mlx4/sense.c
@@ -53,7 +53,7 @@ static int mlx4_SENSE_PORT(struct mlx4_dev *dev, int port,
 
 	if (out_param > 2) {
 		mlx4_err(dev, "Sense returned illegal value: 0x%llx\n", out_param);
-		return EINVAL;
+		return -EINVAL;
 	}
 
 	*type = out_param;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html