netdev - Re: RFC: ethtool: add device-specific feature support in a generic fashion

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 13 Dec 2009 20:19:57 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	peter.p.waskiewicz.jr@...el.com
Cc:	greearb@...delatech.com, netdev@...r.kernel.org,
	eric.dumazet@...il.com, mchan@...adcom.com,
	bhutchings@...arflare.com, linville@...driver.com,
	shemminger@...ux-foundation.org, jesse.brandeburg@...el.com,
	jeffrey.t.kirsher@...el.com
Subject: Re: RFC: ethtool: add device-specific feature support in a generic
 fashion

From: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>
Date: Sat, 12 Dec 2009 23:09:24 -0800

> Excellent points.  Thanks Ben!

See ethtool_gstrings please.

There is no reason to put a "char *" in any of your interfaces, just
as we don't need to in the existing ethtool stats stuff.

And you can put the number of knobs available in struct
ethtool_drvinfo right before n_priv_flags where we have a reserved
area just for adding things like this.

You are specifying way too much new stuff in your datastructures,
unnecessary duplicating existing structures and facilities.

I pointed you at the ethtool private stats stuff because you
can reuse %85 of it's implementation for your purposes :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html