netdev - Re: [PATCH] net: sh_eth alignment fix for sh7724 using NET_IP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091214.215753.147971281.davem@davemloft.net>
Date:	Mon, 14 Dec 2009 21:57:53 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	magnus.damm@...il.com
Cc:	netdev@...r.kernel.org, lethal@...ux-sh.org,
	linux-sh@...r.kernel.org
Subject: Re: [PATCH] net: sh_eth alignment fix for sh7724 using NET_IP_ALIGN

From: Magnus Damm <magnus.damm@...il.com>
Date: Mon, 14 Dec 2009 19:34:43 +0900

> From: Magnus Damm <damm@...nsource.se>
> 
> Fix sh_eth for sh7724 by adding NET_IP_ALIGN support.
> Without this patch the receive data is misaligned.
> 
> Signed-off-by: Magnus Damm <damm@...nsource.se>

How does this interact with sh_eth_set_receive_align() and
why isn't all of the skb_reserve() logic confined to one
place?

The sh7763 sh_eth_my_cpu_data sets rpadir unconditionally,
yet your NET_IP_ALIGN behavior is controlled by the new
setting of .rpadir for sh7724, is this ok or is it going
to break sh7763 or cause it to misbehave?

Could you possibly generalize this so that you don't
need the ifdefs and it doesn't matter what the NET_IP_ALIGN
value actually is?  That is making this code more confusing
than it needs to be.

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html