netdev - [PATCH] bnx2: reset_task is crashing the kernel. Fixing it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1260965365-14255-3-git-send-email-leitao@linux.vnet.ibm.com>
Date:	Wed, 16 Dec 2009 06:09:25 -0600
From:	leitao@...ux.vnet.ibm.com
To:	mchan@...adcom.com
Cc:	netdev@...r.kernel.org, Breno Leitao <leitao@...ux.vnet.ibm.com>
Subject: [PATCH] bnx2: reset_task is crashing the kernel. Fixing it.

Acutally if a BNX2 interface gets time outs, the reset_task is
called to restart the interface. But, the NIC is turned off with
some packages to transmitt, and this causes the function
napi_disable() to loop forever, crashing the kernel.

Signed-off-by: Breno Leitao <leitao@...ux.vnet.ibm.com>
---
 drivers/net/bnx2.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
index f81f082..40c883b 100644
--- a/drivers/net/bnx2.c
+++ b/drivers/net/bnx2.c
@@ -652,8 +652,6 @@ bnx2_napi_enable(struct bnx2 *bp)
 static void
 bnx2_netif_stop(struct bnx2 *bp)
 {
-	bnx2_cnic_stop(bp);
-	bnx2_disable_int_sync(bp);
 	if (netif_running(bp->dev)) {
 		int i;

@@ -667,6 +665,8 @@ bnx2_netif_stop(struct bnx2 *bp)
 			txq->trans_start = jiffies;
 		}
 	}
+	bnx2_cnic_stop(bp);
+	bnx2_disable_int_sync(bp);
 }

 static void
-- 
1.6.0.2

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html