netdev - Re: [PATCH] bnx2: reset_task is crashing the kernel. Fixing it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1260988830.31045.79.camel@nseg_linux_HP1.broadcom.com>
Date:	Wed, 16 Dec 2009 10:40:30 -0800
From:	"Michael Chan" <mchan@...adcom.com>
To:	"leitao@...ux.vnet.ibm.com" <leitao@...ux.vnet.ibm.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH] bnx2: reset_task is crashing the kernel. Fixing it.

On Wed, 2009-12-16 at 04:09 -0800, leitao@...ux.vnet.ibm.com wrote:
> Acutally if a BNX2 interface gets time outs, the reset_task is
> called to restart the interface. But, the NIC is turned off with
> some packages to transmitt, and this causes the function
> napi_disable() to loop forever, crashing the kernel.
> 
> Signed-off-by: Breno Leitao <leitao@...ux.vnet.ibm.com>
> ---
>  drivers/net/bnx2.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/bnx2.c b/drivers/net/bnx2.c
> index f81f082..40c883b 100644
> --- a/drivers/net/bnx2.c
> +++ b/drivers/net/bnx2.c
> @@ -652,8 +652,6 @@ bnx2_napi_enable(struct bnx2 *bp)
>  static void
>  bnx2_netif_stop(struct bnx2 *bp)
>  {
> -	bnx2_cnic_stop(bp);

bnx2_cnic_stop() needs to be done before NAPI is disabled because we
still need to service events in NAPI while stopping cnic.  So we need to
keep the call here.

> -	bnx2_disable_int_sync(bp);
>  	if (netif_running(bp->dev)) {
>  		int i;
>  
> @@ -667,6 +665,8 @@ bnx2_netif_stop(struct bnx2 *bp)
>  			txq->trans_start = jiffies;
>  		}
>  	}
> +	bnx2_cnic_stop(bp);
> +	bnx2_disable_int_sync(bp);

Moving bnx2_disable_int_sync() here looks ok.  Thanks.

>  }
>  
>  static void

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html