lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 17 Dec 2009 19:40:17 +0100 From: Jarek Poplawski <jarkao2@...il.com> To: Jay Vosburgh <fubar@...ibm.com> Cc: Johannes Berg <johannes@...solutions.net>, Mikhail Markine <markine@...gle.com>, netdev@...r.kernel.org, bonding-devel@...ts.sourceforge.net, Petri Gynther <pgynther@...gle.com>, David Miller <davem@...emloft.net> Subject: Re: [Bonding-devel] [PATCH] bonding: cancel_delayed_work() -> cancel_delayed_work_sync() On Thu, Dec 17, 2009 at 08:12:53AM -0800, Jay Vosburgh wrote: > There's already logic in the monitors (bond_mii_monitor, et al) > to check a sentinel (kill_timers) and do nothing (not acquire rtnl) and > return. Btw, this check should be repeated if bond->lock is given back and re-acquired. I can't see these kill_timers used in bond_sysfs.c though. > What exactly is the nature of the race that doing cancel..sync > is fixing? The bond_close function sets kill_timers prior to calling > the cancel functions, so the monitor function might run once, but it > should do nothing. I guess there is a problem with destructions, but I hope Mikhail will give more details. Jarek P. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists