netdev - Re: [PATCH v4 1/1] rps: core implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <65634d660912171304p751e1698mbc9de50dade4317d@mail.gmail.com>
Date:	Thu, 17 Dec 2009 13:04:01 -0800
From:	Tom Herbert <therbert@...gle.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH v4 1/1] rps: core implementation

On Fri, Nov 20, 2009 at 3:40 PM, Stephen Hemminger
<shemminger@...tta.com> wrote:
>
> On Fri, 20 Nov 2009 15:28:58 -0800
> Tom Herbert <therbert@...gle.com> wrote:
>
> > +static char *get_token(const char **cp, size_t *len)
> > +{
> > +     const char *bp = *cp;
> > +     char *start;
> > +
> > +     while (isspace(*bp))
> > +             bp++;
> > +
> > +     start = (char *)bp;
> > +     while (!isspace(*bp) && *bp != '\0')
> > +             bp++;
> > +
> > +     if (start != bp)
> > +             *len = bp - start;
> > +     else
> > +             start = NULL;
> > +
> > +     *cp = bp;
> > +     return start;
> > +}
>
>
> Sysfs is intentionally one value per file. If you need multiple
> values, then it is the wrong interface.

Are there any good recommendations for a more appropriate interface to
use?  Would it make sense to expose the NAPI instances in sysfs...
like eth0/rx-0/, eth0/rx-1/,... which would hopefully be consistent
with interrupts in /proc/interrupts.

Thanks,
Tom
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html