netdev - Re: [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in bcm54xx_adjust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091218014138.GA22080@xw6200.broadcom.net>
Date:	Thu, 17 Dec 2009 17:41:39 -0800
From:	"Matt Carlson" <mcarlson@...adcom.com>
To:	"Roel Kluin" <roel.kluin@...il.com>
cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"Matthew Carlson" <mcarlson@...adcom.com>,
	"Andrew Morton" <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	"davem@...emloft.net" <davem@...emloft.net>
Subject: Re: [PATCH] broadcom: bcm54xx_shadow_read() errors ignored in
 bcm54xx_adjust_rxrefclk()

On Wed, Dec 16, 2009 at 05:02:26AM -0800, Roel Kluin wrote:
> If not signed read errors are ignored.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>

Acked-by: Matt Carlson <mcarlson@...adcom.com>

> ---
> Found using coccinelle: http://coccinelle.lip6.fr/
> 
> diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c
> index f63c96a..c13cf64 100644
> --- a/drivers/net/phy/broadcom.c
> +++ b/drivers/net/phy/broadcom.c
> @@ -326,7 +326,8 @@ error:
>  
>  static void bcm54xx_adjust_rxrefclk(struct phy_device *phydev)
>  {
> -	u32 val, orig;
> +	u32 orig;
> +	int val;
>  	bool clk125en = true;
>  
>  	/* Abort if we are using an untested phy. */
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html