netdev - Re: [RFC PATCH v2 4/6] net: Add netdev ops for SR-IOV configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1261160361.2769.20.camel@achroite.uk.solarflarecom.com>
Date:	Fri, 18 Dec 2009 18:19:21 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	Mitch Williams <mitch.a.williams@...el.com>
Subject: Re: [RFC PATCH v2 4/6] net: Add netdev ops for SR-IOV configuration

On Thu, 2009-12-17 at 17:34 -0800, Jeff Kirsher wrote:
> From: Williams, Mitch A <mitch.a.williams@...el.com>
> 
> Add netdev ops for configuring SR-IOV VF devices through the PF driver.

Though this be restricted to VFs, though?

It is possible to have virtualised interfaces appear as PFs, so they can
easily be passed-through to guests with no IOV support.  HP's 'Virtual
Connect Flex-10' NICs do this, but I'm not sure how they are configured
and whether it is possible to do so from Linux as opposed to firmware.

Solarstorm controllers also have an on-NIC page table and page-
segregated queues that can be mapped into PV guests, which could perhaps
be made configurable in the same way.

[...]
> @@ -660,6 +668,15 @@ struct net_device_ops {
>  #define HAVE_NETDEV_POLL
>  	void                    (*ndo_poll_controller)(struct net_device *dev);
>  #endif
> +	int			(*ndo_set_vf_mac)(struct net_device *dev,
> +						  int queue, u8 *mac);
> +	int			(*ndo_set_vf_vlan)(struct net_device *dev,
> +						   int queue, u16 vlan);
> +	int			(*ndo_set_vf_tx_rate)(struct net_device *dev,
> +						      int vf, int rate);
> +	int			(*ndo_get_vf_config)(struct net_device *dev,
> +						     int vf,
> +						     struct ifla_vf_info *ivf);
[...]

If these remain specific to IOV, presumably they should be guarded by
#ifdef CONFIG_PCI_IOV.

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html