lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20091218.200158.112585402.davem@davemloft.net> Date: Fri, 18 Dec 2009 20:01:58 -0800 (PST) From: David Miller <davem@...emloft.net> To: shemminger@...tta.com Cc: fabio.ludovici@...oo.it, netdev@...r.kernel.org Subject: Re: [PATCH] netem/iproute2 solving correlated loss issues [2/5] From: Stephen Hemminger <shemminger@...tta.com> Date: Fri, 18 Dec 2009 09:36:05 -0800 > On Fri, 18 Dec 2009 12:24:38 +0100 > Fabio Ludovici <fabio.ludovici@...oo.it> wrote: > >> patch 2/5 : linux-2.6.32/net/sched/sch_netem.c > > Could you send with official signed-off-by line please? > > Need some style work to match kernel coding style (not a big issue). > And it would be helpful to put in more descriptive variable names > or documentation. But I will try and address these and resubmit, > keeping you as original author. I would like some kind of commit message which at least explains what in the world this stuff is, how it works, why we want it etc. Furthermore it is fundamentally flawed in it's implementation in that the user exported data structures cannot be changed, you cannot change the layout and you absolutely cannot change the size of these things or else various tool and kernel combinations stop working. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists