netdev - Re: [PATCH] bnx2: reset_task is crashing the kernel. Fixing it.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20091218.202919.70193968.davem@davemloft.net>
Date:	Fri, 18 Dec 2009 20:29:19 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	mchan@...adcom.com
Cc:	leitao@...ux.vnet.ibm.com, netdev@...r.kernel.org
Subject: Re: [PATCH] bnx2: reset_task is crashing the kernel. Fixing it.

From: "Michael Chan" <mchan@...adcom.com>
Date: Wed, 16 Dec 2009 11:15:09 -0800

> 
> On Wed, 2009-12-16 at 11:12 -0800, leitao@...ux.vnet.ibm.com wrote:
>> If bnx2 schedules a reset via the reset_task, e.g., due to a TX
>> timeout, it's possible for the NIC to be disabled with packets
>> pending for transmit.  In this case, napi_disable will loop forever,
>> eventually crashing the kernel.  This patch moves the disable of
>> the device to after the napi_disable call.
>> 
>> Signed-off-by: Breno Leitao <leitao@...ux.vnet.ibm.com>
> 
> Acked-by: Michael Chan <mchan@...adcom.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html