netdev - Re: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 18 Dec 2009 23:14:52 -0800
From:	Joe Perches <joe@...ches.com>
To:	Debashis Dutt <ddutt@...cade.com>
Cc:	netdev@...r.kernel.org, adapter_linux_open_src_team@...cade.com
Subject: Re: Subject: [PATCH 1/6] bna: Brocade 10Gb Ethernet device driver

On Fri, 2009-12-18 at 17:28 -0800, Debashis Dutt wrote:
> +static void bnad_hw_error(struct bnad *bnad, u8 status)
> +{
> +	char message[BNA_MESSAGE_SIZE];
[]
> +			sprintf(message, "Disabling Mbox IRQ %d for port %d",
> +				irq, bnad->bna_id);
> +		pr_info("%s",
> +				message);

All of the char message[BNA_MESSAGE_SIZE] declarations
are not necessary.

These messages are also missing trailing '\n' newlines.

It's better to not indirect via a buffer and simply use:

	pr_<level>("fmt\n", args);

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html