netdev - Re: [PATCH] allow nf_tproxy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-id: <1261379541.11300.6.camel@nessa.odu>
Date:	Mon, 21 Dec 2009 08:12:21 +0100
From:	KOVACS Krisztian <hidden@....bme.hu>
To:	emcnabb@...hat.com
Cc:	DavidMiller <davem@...emloft.net>, netdev@...r.kernel.org,
	sassmann@...hat.com, netfilter-devel@...r.kernel.org
Subject: Re: [PATCH] allow nf_tproxy_core module to unload

Hi,

On Fri, 2009-12-18 at 19:41 -0800, David Miller wrote:
> From: Evan McNabb <emcnabb@...hat.com>
> Date: Fri, 18 Dec 2009 11:24:40 -0500
> 
> > From: Evan McNabb <emcnabb@...hat.com>
> > 
> > Include exit function so nf_tproxy_core module can be removed.
> > 
> > Signed-off-by: Evan McNabb <emcnabb@...hat.com>
> 
> netfilter-devel is the best place to CC: netfilter
> patches, added...
> 
> > 
> > diff --git a/net/netfilter/nf_tproxy_core.c b/net/netfilter/nf_tproxy_core.c
> > index 5490fc3..ec6737c 100644
> > --- a/net/netfilter/nf_tproxy_core.c
> > +++ b/net/netfilter/nf_tproxy_core.c
> > @@ -89,7 +89,12 @@ static int __init nf_tproxy_init(void)
> >  	return 0;
> >  }
> >  
> > +static void __exit nf_tproxy_exit(void)
> > +{
> > +}
> > +
> >  module_init(nf_tproxy_init);
> > +module_exit(nf_tproxy_exit);
> >  
> >  MODULE_LICENSE("GPL");
> >  MODULE_AUTHOR("Krisztian Kovacs");

I'm afraid it's not that simple...

tproxy sets skb->destructor to nf_tproxy_destructor for certain
(redirected) skbs. You must make sure that no skbs have their destructor
set to that function before removing the module.

Cheers,
Krisztian


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html