netdev - Re: [RFC PATCH v2 01/12] ixgbevf: Macros, data structures, useful defines and registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1261420702.2782.3.camel@achroite.uk.solarflarecom.com>
Date:	Mon, 21 Dec 2009 18:38:22 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Cc:	netdev@...r.kernel.org, gospo@...hat.com,
	Greg Rose <gregory.v.rose@...el.com>
Subject: Re: [RFC PATCH v2 01/12] ixgbevf: Macros, data structures, useful
	defines and registers

On Fri, 2009-12-18 at 14:51 -0800, Jeff Kirsher wrote:
> From: Greg Rose <gregory.v.rose@...el.com>
> 
> These two headers define the commonly used macros, data structures,
> register bits and register offsets used by the ixgbevf driver on the
> 82599 virtual function device
> 
[...]
> diff --git a/drivers/net/ixgbevf/defines.h b/drivers/net/ixgbevf/defines.h
> new file mode 100644
> index 0000000..b111771
> --- /dev/null
> +++ b/drivers/net/ixgbevf/defines.h
[...]
> +/* Check whether address is multicast.  This is little-endian specific check.*/
> +#define IXGBE_IS_MULTICAST(Address) \
> +	(bool)(((u8 *)(Address))[0] & ((u8)0x01))
> +
> +/* Check whether an address is broadcast. */
> +#define IXGBE_IS_BROADCAST(Address)              \
> +	((((u8 *)(Address))[0] == ((u8)0xFF)) && \
> +	 (((u8 *)(Address))[1] == ((u8)0xFF)))
[...]

Why not use is_multicast_ether_addr() and  is_broadcast_ether_addr()?

Ben.

-- 
Ben Hutchings, Senior Software Engineer, Solarflare Communications
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html