netdev - Re: [PATCH] wireless: adf702x: new driver for ADF7020/21 parts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1261451102.4041.170.camel@localhost.localdomain>
Date:	Mon, 21 Dec 2009 19:05:02 -0800
From:	Marcel Holtmann <marcel@...tmann.org>
To:	Mike Frysinger <vapier@...too.org>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	uclinux-dist-devel@...ckfin.uclinux.org,
	Michael Hennerich <michael.hennerich@...log.com>
Subject: Re: [PATCH] wireless: adf702x: new driver for ADF7020/21 parts

Hi Mike,

> This is a driver for Analog Devices series of ADF702x Narrow-Band
> Short-Range Radio Transceiver chipsets, including the ADF7021 and
> the ADF7025.  This Ethernet like driver implements a custom
> software PHY.

while it might be a little bit confusing, but the wireless directory
normally only contains Wireless LAN (aka 802.11 and alike) drivers.

If this implements some sort of Ethernet driver, then it might be better
to just put it under drivers/net/ to not intermix and confuse it with
actually 802.11 drivers.

>  drivers/net/wireless/Kconfig   |   11 +
>  drivers/net/wireless/Makefile  |    2 +
>  drivers/net/wireless/adf702x.c |  788 ++++++++++++++++++++++++++++++++++++++++
>  include/linux/spi/adf702x.h    |   33 ++
>  4 files changed, 834 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/net/wireless/adf702x.c
>  create mode 100644 include/linux/spi/adf702x.h

And why is the header file under SPI includes. It could be as easily in
the same directory as the driver *.c file itself. No reason to spread it
over the whole tree if nothing else includes it.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html