lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4B3295BF.6030809@garzik.org>
Date:	Wed, 23 Dec 2009 17:12:15 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	"John W. Linville" <linville@...driver.com>
CC:	netdev@...r.kernel.org, Kalle Valo <kalle.valo@....fi>
Subject: Re: [PATCH] ethtool: add support for at76c50x-usb driver

On 12/23/2009 09:29 AM, John W. Linville wrote:
> Signed-off-by: John W. Linville<linville@...driver.com>
> ---
>   Makefile.am    |    2 +-
>   at76c50x-usb.c |   32 ++++++++++++++++++++++++++++++++
>   ethtool-util.h |    2 ++
>   ethtool.c      |    1 +
>   4 files changed, 36 insertions(+), 1 deletions(-)
>   create mode 100644 at76c50x-usb.c

> +at76c50x_usb_dump_regs(struct ethtool_drvinfo *info, struct ethtool_regs *regs)
> +{
> +	u8 version = (u8)(regs->version>>  24);
> +	u8 rev_id = (u8)(regs->version);
> +	char *ver_string;
> +
> +	if (version != 0)
> +		return -1;
> +
> +	ver_string = hw_versions[rev_id];
> +	fprintf(stdout,
> +		"Hardware Version                    %s\n",
> +		ver_string);
> +
> +	return 0;

applied...  don't forget to update 'version', should the register dump 
data passed to userspace ever change.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ