netdev - [patch] bond_3ad.c avoid possible null deref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20091223132710.GE17923@bicker>
Date:	Wed, 23 Dec 2009 15:27:10 +0200
From:	Dan Carpenter <error27@...il.com>
To:	Jay Vosburgh <fubar@...ibm.com>
Cc:	bonding-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: [patch] bond_3ad.c avoid possible null deref

A few lines earlier we assume that best->slave could be either null or non-null so 
we should check it here as well.

Signed-off-by: Dan Carpenter <error27@...il.com>

--- orig/drivers/net/bonding/bond_3ad.c	2009-12-23 00:06:58.000000000 +0200
+++ devel/drivers/net/bonding/bond_3ad.c	2009-12-23 00:07:31.000000000 +0200
@@ -1580,7 +1580,7 @@ static void ad_agg_selection_logic(struc
 		// check if any partner replys
 		if (best->is_individual) {
 			pr_warning("%s: Warning: No 802.3ad response from the link partner for any adapters in the bond\n",
-				   best->slave->dev->master->name);
+				   best->slave ? best->slave->dev->master->name : "NULL");
 		}
 
 		best->is_active = 1;
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html