netdev - [TCP]: min_t/max_t confusion in tcp_select_initial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B3179B8.5000403@gmail.com>
Date:	Wed, 23 Dec 2009 03:00:24 +0100
From:	Roel Kluin <roel.kluin@...il.com>
To:	"David S. Miller" <davem@...emloft.net>,
	netdev <netdev@...r.kernel.org>
Subject: [TCP]: min_t/max_t confusion in tcp_select_initial_window()?

I could be confused, but in net/ipv4/tcp_output.c:217:

                space = max_t(u32, sysctl_tcp_rmem[2], sysctl_rmem_max);
                space = min_t(u32, space, *window_clamp);
------------------------^^^^^

shouldn't the min_t and max_t be exchanged? i.e.

                space = min_t(u32, sysctl_tcp_rmem[2], sysctl_rmem_max);
                space = max_t(u32, space, *window_clamp);

Thanks, Roel
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html