netdev - Re: [net-next PATCH 5/6] enic: feature add: add ethtool -c/C support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <C757AC34.1B4BB%scofeldm@cisco.com>
Date:	Wed, 23 Dec 2009 11:15:00 -0800
From:	Scott Feldman <scofeldm@...co.com>
To:	Ben Hutchings <bhutchings@...arflare.com>
CC:	<davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [net-next PATCH 5/6] enic: feature add: add ethtool -c/C support

On 12/23/09 10:13 AM, "Ben Hutchings" <bhutchings@...arflare.com> wrote:

> On Mon, 2009-12-21 at 18:21 -0800, Scott Feldman wrote:
>> From: Scott Feldman <scofeldm@...co.com>
>> 
>> Only rx_usec and tx_usec options for ethtool -C are settable as those
>> are the only settings that make sense to HW.  Adds driver reporting of
>> intr coalescing timer value in usec units rather than HW units.
> [...]
>> diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c
>> index 019b148..81cc68d 100644
>> --- a/drivers/net/enic/enic_main.c
>> +++ b/drivers/net/enic/enic_main.c
>> @@ -261,7 +261,63 @@ static void enic_set_msglevel(struct net_device *netdev,
>> u32 value)
>> enic->msg_enable = value;
>>  }
>>  
>> -static const struct ethtool_ops enic_ethtool_ops = {
> [...]
>> +static struct ethtool_ops enic_ethtool_ops = {
> [...]
> 
> I don't see any reason to remove the const here.  Is that an accidental
> change?

That was a mistake.  Sigh.  Let me resend patch set without that change...

[I'll wait a while in case there are any more review comments]

-scott

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html